fix not sending url in conext #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
|
Migrations automatically reviewed with Atlas |
|
Migrations automatically reviewed with Atlas |
ronenlu
force-pushed
the
head_url
branch
3 times, most recently
from
48aa2eb
to
ce8b02e
Compare
ronenlu
commented
Feb 29, 2024
| @@ -596,28 +596,33 @@ func createRunContext(ctx context.Context, act *githubactions.Action) (*atlasexe | |||
| if err := envconfig.Process(ctx, &a); err != nil { | |||
| return nil, fmt.Errorf("failed to load actor: %w", err) | |||
| } | |||
| url := ev.PullRequest.URL | |||
There was a problem hiding this comment.
this logic is taken from the old action:
a8m
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we dont send anything in the url field of the atlas context,
since we use head_commit_url field which is always empty: