add GITHUB_TOKEN permissions to README #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
giautm
reviewed
Mar 19, 2023
giautm
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default permissions for GITHUB_TOKEN does not include
write on PRpermissionsince month ago: https://github.blog/changelog/2023-02-02-github-actions-updating-the-default-github_token-permissions-to-read-only/#:~:text=Previously%2C%20GitHub%20Actions%20gets%20a,to%20read%2Fwrite%20if%20needed.
see default permissions on new repo:
Screen.Recording.2023-03-19.at.14.38.33.mov
Thus, with default permissions users get an
Resource not accessible by integrationErrorsee failing: https://github.com/ronenlu/test_migration/actions/runs/4434852193/jobs/7781295191#step:3:69
but with the permissions specified in the README the workflow is green,
see working: https://github.com/ronenlu/test_migration/actions/runs/4460538212/jobs/7833748560?pr=3
next: need to update README of atlas-sync action and nebula UI