Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/atlas/internal/cmdext: use dev-database schema in ent loader as default schema #1674

Merged
merged 1 commit into from
May 19, 2023
Merged

cmd/atlas/internal/cmdext: use dev-database schema in ent loader as default schema #1674

merged 1 commit into from
May 19, 2023

Conversation

a8m
Copy link
Member

@a8m a8m commented May 19, 2023 •
edited

image

@a8m a8m requested review from rotemtam, giautm and masseelch May 19, 2023 19:22
@a8m
Copy link
Member Author

a8m commented May 19, 2023

Currently, Atlas returns an error in case tables don't have schemas. Soon, we'll add support for generating HCL schemas without schema blocks - make it more dynamic.

giautm
giautm approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@a8m a8m merged commit 07f9535 into master May 19, 2023
25 checks passed
@a8m a8m deleted the loadent branch May 19, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

@masseelch masseelch Awaiting requested review from masseelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a8m @giautm