merge libsql #1716
Merged
merge libsql #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add libsql package and initialize it to make it available for sql.Open Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
Add libsql package and initialize it to make it available for sql.Open Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
a8m
force-pushed
the
haaawk-libsql
branch
3 times, most recently
from
3ce9476
to
b1535aa
Compare
haaawk
reviewed
Jun 4, 2023
haaawk
reviewed
Jun 4, 2023
sql/sqlite/driver.go
Outdated
| sqlclient.DriverOpener(Open), | ||
| sqlclient.RegisterTxOpener(OpenTx), | ||
| sqlclient.RegisterCodec(MarshalHCL, EvalHCL), | ||
| sqlclient.RegisterFlavours("libsql+wss", "libsql+https"), |
There was a problem hiding this comment.
At the moment +https won't work as it does not support interactive transactions and is missing some features. We're working on making it better but maybe it's worth to keep https out of scope for this PR?
haaawk
reviewed
Jun 4, 2023
haaawk
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
I've tested the PR against Turso (managed Libsql) and updated https://github.com/chiselstrike/atlas-integration-ci to use the haaawk-libsql branch for testing. All tests are passing.
Closed
This was referenced Aug 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.