Spelling #1738
Merged
Spelling #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Jun 13, 2023
| - name: Verify generated files are checked in properly | ||
| - name: Verify generated files are checked-in properly |
There was a problem hiding this comment.
This form is already in use in this repository. I think the way it's being used today isn't technically correct, but this matches that style.
If you're actually picky about checked in, those other instances should probably be changed...
| After logging in (not including the first login), you will see all the organizations you have access to. Choose the organization you would to log in to. | ||
| After logging in (not including the first login), you will see all the organizations you have access to. Choose the organization you would to log into. |
There was a problem hiding this comment.
to really shouldn't be left dangling here.
| $ export REPO="username/repo_name" # e.g. "arigia/atlas" | ||
| $ export REPO="username/repo_name" # e.g. "ariga/atlas" |
| and [Fly](https://fly.io/docs/app-guides/continuous-deployment-with-github-actions/) Github actions. For additional | ||
| and [Fly](https://fly.io/docs/app-guides/continuous-deployment-with-github-actions/) GitHub Actions. For additional |
| scorecard((science + mathamatics)/2); | ||
| scorecard((science + mathematics)/2); |
There was a problem hiding this comment.
I'm assuming this is meant to be a word...
| ### Implementing Virtual Generated Columns Columns with Atlas | ||
| ### Implementing Virtual Generated Columns with Atlas |
There was a problem hiding this comment.
I'm assuming this was an unintentionally duplicated word, but I could be wrong....
a8m
reviewed
Jun 13, 2023
|
Thanks a lot for the contribution, @jsoref. It's highly appreciated. I'll merge once CI is green |
a8m
approved these changes
Jun 13, 2023
This was referenced Aug 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/atlas/actions/runs/5254190298#summary-14217513198
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/atlas/actions/runs/5254190498#summary-14217513903