doc/md/guides: automatic migration planning for beego #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
approved these changes
Jul 10, 2023
giautm
reviewed
Jul 10, 2023
|
|
||
| Install the provider by running: | ||
| ```bash | ||
| go get -u ariga.io/atlas-provider-beego |
There was a problem hiding this comment.
Suggested change
| go get -u ariga.io/atlas-provider-beego | |
| go install ariga.io/atlas-provider-beego@latest |
There was a problem hiding this comment.
I still think this is the right way for the standalone mode because the user will not depend on atlas-provider-beego in their code base. And usage of go run -mod will cause their go.sum/go.mod changes every time they run the atlas command.
giautm
reviewed
Jul 10, 2023
Comment on lines
+79
to
+82
| "go", | ||
| "run", | ||
| "-mod=mod", | ||
| "ariga.io/atlas-provider-beego", |
There was a problem hiding this comment.
If we install the binary on the system, then we just need the program name to run.
Suggested change
| "go", | |
| "run", | |
| "-mod=mod", | |
| "ariga.io/atlas-provider-beego", | |
| "atlas-provider-beego", |
giautm
reviewed
Jul 10, 2023
giautm
reviewed
Jul 10, 2023
| ``` | ||
| See [atlasgo.io](https://atlasgo.io/getting-started#installation) for more installation options. | ||
|
|
||
| Install the provider by running: |
There was a problem hiding this comment.
Install the provider only needed if the user uses a standalone mode, right?
Co-authored-by: Giau. Tran Minh <giau.tmg@gmail.com>
This was referenced Aug 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.