Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/atlas: remove revision-schema flag from migrate diff #1978

Merged
merged 1 commit into from
Aug 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmd/atlas/internal/cmdapi/migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,6 @@ type migrateDiffFlags struct {
schemas []string
lockTimeout time.Duration
format string
revisionSchema string // revision schema name
qualifier string // optional table qualifier
}

Expand Down Expand Up @@ -556,7 +555,6 @@ directory state to the desired schema. The desired state can be another connecte
addFlagDevURL(cmd.Flags(), &flags.devURL)
addFlagDirURL(cmd.Flags(), &flags.dirURL)
addFlagDirFormat(cmd.Flags(), &flags.dirFormat)
addFlagRevisionSchema(cmd.Flags(), &flags.revisionSchema)
addFlagSchemas(cmd.Flags(), &flags.schemas)
addFlagLockTimeout(cmd.Flags(), &flags.lockTimeout)
addFlagFormat(cmd.Flags(), &flags.format)
Expand Down
19 changes: 9 additions & 10 deletions doc/md/reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,15 @@ directory state to the desired schema. The desired state can be another connecte
```
#### Flags
```
--to strings [driver://username:password@address/dbname?param=value] select a desired state using the URL format
--dev-url string [driver://username:password@address/dbname?param=value] select a dev database using the URL format
--dir string select migration directory using URL format (default "file://migrations")
--dir-format string select migration file format (default "atlas")
--revisions-schema string name of the schema the revisions table resides in
-s, --schema strings set schema names
--lock-timeout duration set how long to wait for the database lock (default 10s)
--format string Go template to use to format the output
--qualifier string qualify tables with custom qualifier when working on a single schema
--edit edit the generated migration file(s)
--to strings [driver://username:password@address/dbname?param=value] select a desired state using the URL format
--dev-url string [driver://username:password@address/dbname?param=value] select a dev database using the URL format
--dir string select migration directory using URL format (default "file://migrations")
--dir-format string select migration file format (default "atlas")
-s, --schema strings set schema names
--lock-timeout duration set how long to wait for the database lock (default 10s)
--format string Go template to use to format the output
--qualifier string qualify tables with custom qualifier when working on a single schema
--edit edit the generated migration file(s)

```

Expand Down