sql/postgres: Avoid using referential_constraints view
#2025
Conversation
|
Sorry didn’t mean to unmark draft. Tried to click “run tests” with my chubby fingers |
remen
changed the title
referential_constraints view
No worries. I updated the title & description with what I think this solves. I'm a bit unsure on how to take it from here though. Should I add a test case? Should I try to find out why it breaks for cockroach db? Happy to continue the conversation on discord if that's better for you. |
|
Latest commit should make it compatible with cockroachdb. Feel free to run tests again. |
| CASE con.confupdtype | ||
| WHEN 'c' THEN 'CASCADE' | ||
| WHEN 'n' THEN 'SET NULL' | ||
| WHEN 'd' THEN 'SET DEFAULT' | ||
| WHEN 'r' THEN 'RESTRICT' | ||
| WHEN 'a' THEN 'NO ACTION' | ||
| END AS update_rule, | ||
| CASE con.confdeltype | ||
| WHEN 'c' THEN 'CASCADE' | ||
| WHEN 'n' THEN 'SET NULL' | ||
| WHEN 'd' THEN 'SET DEFAULT' | ||
| WHEN 'r' THEN 'RESTRICT' | ||
| WHEN 'a' THEN 'NO ACTION' | ||
| END AS delete_rule |
There was a problem hiding this comment.
I prefer to append the con.confupdtype, con.confdeltype to the query and do this mapping in Go.
There are small test cases to change then in inspect_test.go and maybe add another one in internal/integration/testdata/postgres.
There was a problem hiding this comment.
Thanks for the feedback @a8m! I had a look at doing it this way, but the problem is that both MySQL and Postgres go through the same code path in sqlx.SchemaFKs, and I couldn't find a way to resolve this without more refactoring than I'm comfortable with.
I think handing it over to you is better at this point.
Replace usage of
referential_constraintswith manual switch/case when introspecting foreign key constraints in postgresql. Theswitch/caselogic was copied from thereferential_constraintsview DDL.Rationale:
referential_constraintsview does not contain a reference to the table containing the constraint, which leads to duplicate entries. Fixes foreign keys in different tables with the same name couple on update and on delete behavior #1449referential_constraintsview has some ownership clauses that prevents lookups from being successful if a user only hasSELECTaccess. Fixes Postgres: missing FK constraints for non-owner #1940