Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/postgres: support add enum values before/after exisiting values #2255

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

a8m
Copy link
Member

@a8m a8m commented Nov 5, 2023

Fixed #2252

@a8m a8m merged commit 2809d99 into master Nov 5, 2023
25 checks passed
@a8m a8m deleted the enumvalue branch November 5, 2023 15:56
@atazangene
Copy link

nice, I can not believe how much fast you have fixed this issue, great team....

@a8m
Copy link
Member Author

a8m commented Nov 7, 2023

❤️

@acrogenesis
Copy link

Hi @a8m i'm getting this error using atlas version v0.19.1-63b2061-canary .
I added a value and removed two values from notification_type enum

Error: template: schema_diff:2:3: executing "schema_diff" at <sql $>: error calling sql: reordering enum "notification_type" value "info" is not supported

@a8m
Copy link
Member Author

a8m commented Feb 5, 2024

Hey! As Atlas reported, there's no way to apply such change (drop these two values) in PostgreSQL (in a clean/safe way, without touching the pg_enum table). Do you expect anything specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replacing or reordering enum ("ENUM NAME") value is not supported:
4 participants