Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/atlas: pipe docker run errors to the user #2285

Merged
merged 1 commit into from
Nov 14, 2023
Merged

cmd/atlas: pipe docker run errors to the user #2285

merged 1 commit into from
Nov 14, 2023

Conversation

a8m
Copy link
Member

@a8m a8m commented Nov 14, 2023 •
edited

Before:

Error: exit status 125

After:

Error: running docker arigaio/mysql:8: docker: Cannot connect to the Docker daemon at unix:///.docker/run/docker.sock. Is the docker daemon running?.
See 'docker run --help'.

@a8m a8m requested review from rotemtam, giautm, masseelch and a team November 14, 2023 16:35
giautm
giautm approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 😍

@a8m a8m merged commit 8b73a11 into master Nov 14, 2023
25 checks passed
@a8m a8m deleted the checkdocker branch November 14, 2023 16:43
@BrewTestBot BrewTestBot mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

@masseelch masseelch Awaiting requested review from masseelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a8m @giautm