-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/md/guides: documenting working with secrets #2320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseelch
reviewed
Nov 27, 2023
doc/md/guides/deploying/secrets.mdx
Outdated
|
||
IAM authentication is a mechanism that allows users to authenticate to a database using their cloud provider credentials. | ||
The main advantage of IAM authentication is that it allows users to avoid storing database credentials altogether. Although | ||
setting this up, it is considered a best practice for many cloud providers. IAM authentication is also more secure than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is missing a word like is cumbersome
ronenlu
reviewed
Nov 27, 2023
ronenlu
reviewed
Nov 27, 2023
rotemtam
commented
Nov 28, 2023
Co-authored-by: Ronen Lubin <63970571+ronenlu@users.noreply.github.com>
masseelch
approved these changes
Nov 28, 2023
masseelch
reviewed
Nov 28, 2023
<Tabs | ||
defaultValue="aws-rds-iam" | ||
values={[ | ||
{label: 'aws_rds_token', value: 'aws-rds-iam'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
{label: 'aws_rds_token', value: 'aws-rds-iam'}, | |
{label: 'AWS RDS Token', value: 'aws-rds-iam'}, |
Maybe like that though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.