Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/md/guides: documenting working with secrets #2320

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

rotemtam
Copy link
Member

No description provided.

@rotemtam rotemtam requested review from a8m, hilakashai and a team November 27, 2023 12:25

IAM authentication is a mechanism that allows users to authenticate to a database using their cloud provider credentials.
The main advantage of IAM authentication is that it allows users to avoid storing database credentials altogether. Although
setting this up, it is considered a best practice for many cloud providers. IAM authentication is also more secure than
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing a word like is cumbersome

Co-authored-by: Ronen Lubin <63970571+ronenlu@users.noreply.github.com>
<Tabs
defaultValue="aws-rds-iam"
values={[
{label: 'aws_rds_token', value: 'aws-rds-iam'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{label: 'aws_rds_token', value: 'aws-rds-iam'},
{label: 'AWS RDS Token', value: 'aws-rds-iam'},

Maybe like that though?

@rotemtam rotemtam merged commit 216fd83 into master Nov 29, 2023
2 checks passed
@rotemtam rotemtam deleted the r/secretdoc branch November 29, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants