sql/postgres: use native pg time types #686
Conversation
| } | ||
|
|
||
| // formatTime overrides the default printing logic done by schemahcl.hclType. | ||
| func formatTime() specutil.TypeSpecOption { |
There was a problem hiding this comment.
Should the driver know about hcl?
There was a problem hiding this comment.
This is why I added the Printer prop you removed in this PR @a8m
There was a problem hiding this comment.
The driver knows nothing about hcl. It's the same schemaspec API that exists today. However, since there is some reflection/parsing logic going on there, I added this comment to make the life easier for future readers.
I don't think the Printer is needed. From its name, I assumed the printer was used for printing, but that's was not the case (print to driver presentation and then call Parse). Instead, I'd add something like WithTypeParser to allow overriding the parsing logic of one typespec if we'll need something like this to avoid one layer of abstraction.
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
No description provided.