Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: improve CD #4

Merged
merged 4 commits into from May 15, 2023
Merged

.github/workflows: improve CD #4

merged 4 commits into from May 15, 2023

Conversation

yonidavidson
Copy link
Contributor

@yonidavidson yonidavidson commented May 10, 2023 •
edited

No description provided.

@yonidavidson yonidavidson force-pushed the fix-deploy branch 8 times, most recently from 0f025a6 to 0fc1336 Compare May 11, 2023 10:41
@yonidavidson yonidavidson requested a review from a team May 11, 2023 12:01
rotemtam
rotemtam approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , just please qualify the name of the artifact to avoid any weird collisions

@yonidavidson yonidavidson force-pushed the fix-deploy branch 4 times, most recently from 19fb014 to d56dfbb Compare May 15, 2023 08:42
@yonidavidson yonidavidson merged commit cb0ad91 into master May 15, 2023
1 check passed
@yonidavidson yonidavidson deleted the fix-deploy branch May 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yonidavidson @rotemtam