Inline AncestralSequence::mlCharProbAt
and AncestralSequence::mlCharProbAtF
methods
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ari!
I was exploring the PRANK code and doing some profiling to see if I could make it any faster. After profiling with Valgrind, I found that the
AncestralSequence::mlCharProbAt
was in a very hot path: on my example of 12 sequences, it was being called 3M times, with a total cycle count of 150M cycles, out of a total execution of 400M cycles.However, all this function is doing is loading data from memory, so it's not really normal to take 50 cycles per fetch; besides, hiding it in a function prevents the CPU from pipelining load instructions when used inside of a loop. By inlining this one function, the same invokation of PRANK went from 400M cycles to 250M cycles.
In terms of timing, that's how it improved on my machine: