Feature Request: support for redis-sentinel

[cdent]

We're in the process of adding your puppet-redis module to openstack-puppet-modules and have decided it would be handy to have sentinel support in this module.

I'm happy to do this work myself and submit a pull-request but I wanted to check first on the following:

• Would you accept it?
• Have you got something in progress already?

Thanks.

[arioch]

I haven't got anything in progress but I'd gladly accept patches!
Other enhancements are welcome too.

[cdent]

Cool, this is on my todo list for this week. There are some hurdles to overcome with the sentinel.conf file (which the sentinel process will write state to) but I've seen some ways around that.

[arioch]

Looking forward to seeing some patches. 👍
You could use augeas so you don't have to manage the entire file which would otherwise result in a race condition.

[cdent]

I'll be doing the work on this fork+branch: https://github.com/cdent/puppet-redis/tree/sentinel-support

Do you prefer the eventual pull request (assuming I can get it working, which I'm pretty sure I can) squashed or with all the history?

[arioch]

Excellent. I see you already got started. :)

Well it depends on how many commits you're going to end up with.
If it's +50 I'd prefer some of them squashed, but if it's 10 commits by all means leave it in.

Keep up the good work!

[cdent]

I've left a few comments in the message of today's commit that you might want to weigh in on: cdent@8206296

They basically surround questions on how or if to deal with config directories and log files.

[cdent]

Released in f4ffa1b

Awesome, thanks for the quick handling.