Skip to content

Commit

Permalink
Close #46
Browse files Browse the repository at this point in the history
- This commit adds a 'mode' keyword argument to the set_members method. The
set_members method already looks to get the lacp_mode in use from existing
members but ultimately uses 'on' if no other members exist. This commit
allows you to supercede that pass in the desired lacp mode.
  • Loading branch information
phil-dileo committed Oct 15, 2015
1 parent 836d2d3 commit 75f5e87
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions pyeapi/api/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ def get_members(self, name):
return re.findall(r'\b(?!Peer)Ethernet[\d/]*\b',
config[0]['result']['output'])

def set_members(self, name, members):
def set_members(self, name, members, mode=None):
"""Configures the array of member interfaces for the Port-Channel
Args:
Expand All @@ -600,11 +600,17 @@ def set_members(self, name, members):
members(list): The list of Ethernet interfaces that should be
member interfaces
mode(str): The LACP mode to configure the member interfaces to.
Valid values are 'on, 'passive', 'active'
Returns:
True if the operation succeeds otherwise False
"""
current_members = self.get_members(name)
lacp_mode = self.get_lacp_mode(name)
if mode:
lacp_mode = mode
else:
lacp_mode = self.get_lacp_mode(name)
grpid = re.search(r'(\d+)', name).group()

commands = list()
Expand Down

0 comments on commit 75f5e87

Please sign in to comment.