Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement for sending requests #18

Closed
devrobo opened this issue Jul 9, 2015 · 2 comments
Closed

Performance improvement for sending requests #18

devrobo opened this issue Jul 9, 2015 · 2 comments
Assignees
Milestone

Comments

@devrobo
Copy link
Contributor

devrobo commented Jul 9, 2015

The Capi team discovered a 40 ms delay that happens on subsequent requests to a keepalive connection between when the client sends its headers and when it sends the rest of the data (this is due to an interaction of a deferred ACK on the server side and nagle's algorithm on the client side). This can be addressed by sending the data in the endheaders request.

It would also be nice to have a benchmark of the pyeapi library so that we can see the performance improvement of this change.

@phil-dileo
Copy link
Contributor

I think this might already be factored into the code. See: https://github.com/arista-eosplus/pyeapi/blob/develop/pyeapi/eapilib.py#L364

@devrobo devrobo added this to the 0.5.0 milestone Nov 23, 2015
devrobo added a commit that referenced this issue Jan 4, 2016
@phil-dileo
Copy link
Contributor

Fixed with #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants