Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 support (and migrate to GitHub actions) #223

Closed
wants to merge 4 commits into from

Conversation

stefanor
Copy link
Contributor

Iterable moved to collections.abc in 3.3

Fixes: #195

While we're here, migrate to GitHub actions, so we can have CI, again.

runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.5', '3.6', '3.7', '3.8', '3.9', '3.10']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything below Python 3.7 is EOL. I suggest to stick to supported Python releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'd be sensible. I don't know what the maintainers want to be supporting, though?

@shimamizu
Copy link

@dlyssenko this seems pretty straight forward? Would be good to get 3.10 support.

@dlyssenko
Copy link
Contributor

dlyssenko commented Sep 23, 2022

@stefanor, @shimamizu, @fabaff. W.r.t. switching over to Github workflow (ebdbb24) - I'm myself in favor of this decision, probably will approve after checking with my team.

For the supported versions in CI (cc9c584) - I'd think we still need even 2.7 - some of our customers might still use it, documentations is still being built using sphinx on python2, EOS integration still relies on python2 and system tests are not yet entirely migrated over to python3. We're making an effort to migrate completely to python3, but it takes time, until then we'd need to include 2.7 into the CI workflow.

for the same reason I cannot approve 81754f5 - but PR #235, #239 ensure compatibility, so that one could be dropped entirely.

@dlyssenko
Copy link
Contributor

  1. I've merged ebdbb24 manually through git cherry-pick,
  2. will also update python-version manually to extend to 2.7
  3. the other commits (cc9c584, 81754f5) are not required, as per my update earlier.

closing this PR with that.

@dlyssenko dlyssenko closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warninig - collections import for python 3.3+
4 participants