fix for issue #286 - traceback when banner section contains white-spaces lines #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlyssenko
changed the title
mharista
previously approved these changes
Dec 5, 2023
hmm, good point. Currently, the updated UT file handles only blank lines (empty and with the white spaces). In order to handle rogue configs, I'd need to come up with the negative test case. Will do soon |
|
@mharista, I have added a false positive case to UT fixture file to cover the case, please review |
|
I've ran also systest (with the latest update) - all have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes issue #286
The issue has been introduced with PR#220 - that PR introduced cached parsing of the running config, which is mostly indent-structured text, however, we entirely overlooked a banner section.
Unlike the rest of the config, the banner section(s) is a free text (i.e. unstructured) and therefore may produce:
The banner is now parsed into a separate section.