Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add '--log-file' option to send logs to a file and introduced '--prompt' CLI option to prompt for passwords #344

Merged
merged 14 commits into from
Aug 8, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Aug 7, 2023

Logging

If a file is provided, logs will also be sent to the file in addition to stdout.
If a file is provided and logging level is DEBUG, only the logging level INFO and higher will
be logged to stdout while all levels will be logged in the file.

Add test execution time logs in DEBUG level

Timeout

Changed default timeout to 30 sec

Password prompt

Introduced --prompt to ask ANTA to prompt password that have not been provided by CLI options or environment variables.

@mtache mtache changed the title feat: add --log-file option to send logs to a file feat: add --log-file option to send logs to a file and introduced '--prompt' CLI option to prompt for passwords Aug 7, 2023
@mtache mtache changed the title feat: add --log-file option to send logs to a file and introduced '--prompt' CLI option to prompt for passwords feat: add '--log-file' option to send logs to a file and introduced '--prompt' CLI option to prompt for passwords Aug 7, 2023
@titom73 titom73 added documentation Improvements or additions to documentation framework-enhancement New feature or request labels Aug 8, 2023
docs/README.md Outdated
@@ -65,8 +71,8 @@ Commands:
nrfu Run NRFU against inventory devices
```

!!! info
`username`, `password`, `enable`, and `enable-password` values are the same for all devices
> [!NOTE]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems GH markdown flavor is not supported by material for mkdocs. Rendering is not optimal

[!NOTE] username, password, enable-password, enable, timeout and insecure values are the same for all devices

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the opposite is also true.. I chose the GitHub-compatible [!NOTE] annotation for the GitHub README page because !!! info is not rendered.
Maybe should we just use:

> username, password, enable-password, enable, timeout and insecure values are the same for all devices

So GitHub and mkdocs are happy ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do that ☮️

@mtache mtache merged commit 3ce2d70 into arista-netdevops-community:main Aug 8, 2023
17 checks passed
@mtache mtache deleted the FileHandler branch August 8, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation framework-enhancement New feature or request rn: feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants