Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests)!: Update VerifySyslog #356

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

carl-baillargeon
Copy link
Collaborator

@carl-baillargeon carl-baillargeon commented Aug 9, 2023

Move anta.tests.system.VerifySyslog test to anta.tests.logging.VerifyLoggingErrors.

For now, the test has been modified to verify syslog messages with a severity of ERRORS or higher instead of WARNING.

The last 7 days has been removed as well to optimize test performance on devices with large log buffers.

This test can be revisited in the future once we implement caching in #342.

Fixes: #332

@carl-baillargeon carl-baillargeon requested review from mtache and titom73 and removed request for mtache August 9, 2023 19:58
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 merged commit cb69210 into arista-netdevops-community:main Aug 10, 2023
21 of 22 checks passed
@carl-baillargeon carl-baillargeon deleted the issue/332 branch May 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifySyslog test is way too CPU hungry
2 participants