Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Update Interface custom type #409

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(anta.tests): Update Interface custom type #409

merged 2 commits into from
Sep 22, 2023

Conversation

carl-baillargeon
Copy link
Collaborator

Description

Update the Interface custom type to support sub-interfaces.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

titom73
titom73 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@titom73 titom73 added bug Something isn't working network-tests labels Sep 22, 2023
@titom73 titom73 added this to the v0.8.0 milestone Sep 22, 2023
@gmuloc gmuloc merged commit 8c31823 into arista-netdevops-community:main Sep 22, 2023
17 checks passed
@carl-baillargeon carl-baillargeon deleted the fix/interfaces_model branch May 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
bug Something isn't working network-tests rn: fix(anta.tests)
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carl-baillargeon @titom73 @gmuloc