Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Fix VerifyVxlanVtep result failure messages #433

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(anta.tests): Fix VerifyVxlanVtep result failure messages #433

merged 1 commit into from
Oct 26, 2023

Conversation

carl-baillargeon
Copy link
Collaborator

Description

Added sorted() to the set objects to guarantee order in the failure messages.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

mtache
mtache approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine !

@mtache mtache merged commit 0ccf865 into arista-netdevops-community:main Oct 26, 2023
16 checks passed
@titom73 titom73 mentioned this pull request Nov 11, 2023
Merged
@carl-baillargeon carl-baillargeon deleted the fix/verifyvxlanvtep branch May 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

@titom73 titom73 Awaiting requested review from titom73

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carl-baillargeon @mtache