Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error handling and ansible group parsing of anta get from-ansible #449

Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix: improve error handling and ansible group parsing of anta get from-ansible #449

merged 4 commits into from
Nov 10, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Nov 9, 2023 •
edited by gmuloc

Description

Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

gmuloc
gmuloc approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok if CI passes

@gmuloc gmuloc merged commit b982f55 into arista-netdevops-community:main Nov 10, 2023
25 checks passed
@titom73 titom73 mentioned this pull request Nov 11, 2023
Merged
@mtache mtache deleted the fix-inventory-from-ansible branch April 10, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@mtache mtache

Labels
rn: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtache @gmuloc