Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Add quotes around version name in VerifyEOSVersion #471

Merged
merged 4 commits into from
Nov 21, 2023
Merged

fix(anta.tests): Add quotes around version name in VerifyEOSVersion #471

merged 4 commits into from
Nov 21, 2023

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Nov 20, 2023

Description

Fixes #465

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

gmuloc
gmuloc requested changes Nov 21, 2023
View reviewed changes
anta/tests/software.py Outdated Show resolved Hide resolved
anta/tests/software.py Show resolved Hide resolved
examples/tests.yaml Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@gmuloc gmuloc merged commit b4162e2 into arista-netdevops-community:main Nov 21, 2023
19 checks passed
@titom73 titom73 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@mtache mtache Awaiting requested review from mtache

Assignees

@titom73 titom73

Labels
network-tests rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(anta.tests): Add quotes around version name in VerifyEOSVersion
2 participants
@titom73 @gmuloc