Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.tests): New BGP EVPN Type-2 route test #519

Merged
merged 7 commits into from
Feb 7, 2024
Merged

feat(anta.tests): New BGP EVPN Type-2 route test #519

merged 7 commits into from
Feb 7, 2024

Conversation

carl-baillargeon
Copy link
Collaborator

@carl-baillargeon carl-baillargeon commented Jan 10, 2024 •
edited

Description

This test verifies the EVPN Type-2 routes for a given IPv4 or MAC address and VNI.

Expected Results:
* success: If all provided VXLAN endpoints have at least one valid and active path to their EVPN Type-2 routes.
* failure: If any of the provided VXLAN endpoints do not have at least one valid and active path to their EVPN Type-2 routes.

  • Added new test
  • Cleanup old BGP function
  • Added new pydantic_extra_types to requirements

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB
MaheshGSLAB reviewed Jan 12, 2024
View reviewed changes
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/routing/test_bgp.py Outdated Show resolved Hide resolved
MaheshGSLAB
MaheshGSLAB approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@titom73 titom73 added state: conflict validated PR validated, waiting for conflict resolution or PR merge party and removed one-more-review labels Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc merged commit ef2b4ae into arista-netdevops-community:main Feb 7, 2024
19 checks passed
@carl-baillargeon carl-baillargeon deleted the feat/evpn-type-2 branch May 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

@mtache mtache Awaiting requested review from mtache

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: feat(anta.tests) validated PR validated, waiting for conflict resolution or PR merge party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carl-baillargeon @titom73 @MaheshGSLAB @gmuloc