feat(anta.tests): Added testcase to verify Login and Motd banner #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
reviewed
Jan 17, 2024
| "test": VerifyBannerLogin, | ||
| "eos_data": [ | ||
| { | ||
| "loginBanner": "Copyright (c) 2023 Arista Networks, Inc.\nUse of this source code is governed by the Apache License 2.0\n" |
There was a problem hiding this comment.
can you test with a multiline banner entry?
"""
opyright (c) 2023-2024 Arista Networks, Inc.
Use of this source code is governed by the Apache License 2.0
"""
There was a problem hiding this comment.
In device json output will be same as eos_data so i add the support if i user want to give multiline banner as input.
32ef660
carl-baillargeon
merged commit bd836f4
into
arista-netdevops-community:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added testcase to verify Login and Motd banner.
Fixes #524
Checklist:
pre-commit run)tox -e testenv)