Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Fix VerifyLLDPNeighbors to support multiple LLDP neighbors on the same port #586

Merged
merged 3 commits into from
Apr 12, 2024
Merged

fix(anta.tests): Fix VerifyLLDPNeighbors to support multiple LLDP neighbors on the same port #586

merged 3 commits into from
Apr 12, 2024

Conversation

carl-baillargeon
Copy link
Collaborator

@carl-baillargeon carl-baillargeon commented Mar 14, 2024 •
edited by gmuloc

Description

Fix VerifyLLDPNeighbors test to support multiple neighbors on the same port.

Update failure message to a more human readable format to make AVD report happy.

Addresses aristanetworks/avd#3737

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB
MaheshGSLAB reviewed Mar 19, 2024
View reviewed changes
anta/tests/connectivity.py Outdated Show resolved Hide resolved
anta/tests/connectivity.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_connectivity.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_connectivity.py Outdated Show resolved Hide resolved
@carl-baillargeon carl-baillargeon added this to the v1.0.0 milestone Mar 27, 2024
MaheshGSLAB
MaheshGSLAB approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc reviewed Mar 27, 2024
View reviewed changes
anta/tests/connectivity.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Mar 27, 2024
View reviewed changes
anta/tests/connectivity.py Outdated Show resolved Hide resolved
@mtache mtache merged commit fff2f9d into arista-netdevops-community:main Apr 12, 2024
17 checks passed
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
@carl-baillargeon carl-baillargeon deleted the fix/lldp_test branch May 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carl-baillargeon @gmuloc @MaheshGSLAB @mtache