Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(anta.tests): Update custom-tests.md to reflect the new test docstring format #598

Merged
merged 2 commits into from
Mar 22, 2024
Merged

doc(anta.tests): Update custom-tests.md to reflect the new test docstring format #598

merged 2 commits into from
Mar 22, 2024

Conversation

carl-baillargeon
Copy link
Collaborator

@carl-baillargeon carl-baillargeon commented Mar 21, 2024 •
edited

Description

Fixes #593

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.0.0 milestone Mar 22, 2024
gmuloc
gmuloc approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@gmuloc gmuloc changed the title fix(anta.tests): Update custom-tests.md to reflect the new test docstring format doc(anta.tests): Update custom-tests.md to reflect the new test docstring format Mar 22, 2024
@gmuloc gmuloc merged commit 3f10322 into arista-netdevops-community:main Mar 22, 2024
18 checks passed
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
@carl-baillargeon carl-baillargeon deleted the fix/custom-tests-doc branch May 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: doc(anta.tests)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

doc: Fix https://www.anta.ninja/main/advanced_usages/custom-tests/
2 participants
@carl-baillargeon @gmuloc