New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove AntaMissingParamException #612

Merged

mtache merged 10 commits into arista-netdevops-community:main from gmuloc:issue/405

Apr 10, 2024

Collaborator

gmuloc commented Mar 28, 2024 •

edited by mtache

Fixes #405

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)


          refactor: Remove exception

fae04f0

github-actions bot assigned gmuloc

gmuloc changed the title ~~Refactor: Remove AntaMissingParamException~~ refactor: Remove AntaMissingParamException

gmuloc added this to the v1.0.0 milestone

gmuloc added 4 commits

March 29, 2024 10:13


          WIP: not working

8851e3b


          Refactor: Make AntaTemplate params typed again

2374ff7


          Merge branch 'main' into issue/405


          refactor: Blocking extra params like a star

gmuloc marked this pull request as ready for review

April 4, 2024 15:50

carl-baillargeon reviewed

View reviewed changes

anta/tests/connectivity.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/models.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/models.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/connectivity.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/security.py Outdated Show resolved Hide resolved

gmuloc added 2 commits

April 4, 2024 20:00


          refactor: Address some comments

f83e494


          refactor: More stuff

e3ee50f

carl-baillargeon reviewed

View reviewed changes

anta/tests/services.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

carl-baillargeon reviewed

View reviewed changes

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved

gmuloc added 2 commits

April 4, 2024 22:14


          refactor: More stuff

af7a134


          refactor: More stuff

5c327fa

MaheshGSLAB reviewed

View reviewed changes

anta/tests/security.py Outdated Show resolved Hide resolved


          refactor: Address PR comments

ede348b

mtache merged commit 76c7835 into arista-netdevops-community:main

20 checks passed

github-actions bot added the rn: refactor label

gmuloc mentioned this pull request

bump: Version 0.13.0 -> 0.14.0 #629

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment