Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: (eos_snapshot): fix var name in input example #1960

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Doc: (eos_snapshot): fix var name in input example #1960

merged 1 commit into from
Jul 26, 2022

Conversation

matthewgottlieb
Copy link
Contributor

Change Summary

Docs for eos_snapshot include an example with variable commands_to_collect (used earlier in development), which should be commands_list.

Component(s) name

arista.avd.eos_snapshot

Proposed changes

Update example in docs.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@matthewgottlieb matthewgottlieb requested a review from a team as a code owner July 25, 2022 20:58
gmuloc
gmuloc approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

tgodaA
tgodaA approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the Doc dix

@tgodaA tgodaA merged commit 86df533 into aristanetworks:devel Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@tgodaA tgodaA tgodaA approved these changes

Assignees

@matthewgottlieb matthewgottlieb

Labels
role: eos_snapshot state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewgottlieb @gmuloc @tgodaA