Feat(eos_validate_state): skip lldp topology for shutdown

[chetryan]

Change Summary

Skip checking LLDP topology for interfaces that are shutdown: true.

When a device in the inventory has is_deployed: false and the global value shutdown_interfaces_towards_undeployed_peers: true is set, the interfaces towards devices that have not been deployed will be in the shutdown state.
In the above case, we should skip checking for lldp neighborships as we will not find any lldp peers if the interface is shutdown.

Related Issue(s)

Fixes #2110

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Adds a check to make sure interface is not shutdown before checking lldp neighborship.
not (ethernet_interface.value.shutdown is undefined or ethernet_interface.value.shutdown) and so that the logic becomes:

when: |
    (ethernet_interfaces is defined and ethernet_interfaces is not none) and
    not (ethernet_interface.value.shutdown is undefined or ethernet_interface.value.shutdown) and
    (ethernet_interface.value.peer is defined and ethernet_interface.value.peer is not none) and
    (ethernet_interface.value.peer_interface is defined and ethernet_interface.value.peer_interface is not none) and
    (hostvars[ethernet_interface.value.peer] is defined and hostvars[ethernet_interface.value.peer] is not none) and
    (hostvars[ethernet_interface.value.peer]['dns_domain'] is defined and hostvars[ethernet_interface.value.peer]['dns_domain'] is not none)

How to test

There are currently no Molecule tests for eos_validate_state

Checklist

User Checklist

• Tested on actual topology inside Lab.

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[ClausHolbechArista]

For the case of shutdown being undefined I don't think we should skip this test. EOS has global knobs that can inverse the default state of the interface, so you cannot deduct it the interface is shutdown or not based on a missing variable. Apart from that, I support the rest of the change. I did some fundamental changes to validate_state in another PR, so we will probably need some rebasing and fix merge conflicts when the first one merges.

The logic could be ... and ethernet_interface.shutdown is not arista.avd.defined(true) and ...

[ClausHolbechArista]

Approved but please make tests pass
https://github.com/aristanetworks/ansible-avd/actions/runs/3386366101/jobs/5625683269

[tgodaA]

LGTM