Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Uplink native vlan for l2 switches #2522

Merged

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Uplink native vlan for l2 switches

Component(s) name

arista.avd.eos_designs

Proposed changes

< node_type_key >:

  defaults:
    # Uplink native vlan | Optional
    # Only applicable to switches with layer-2 port-channel uplinks
    # The vlan will be created in both ends of the link even if it is not defined under network services
    # By default the uplink will not have a native_vlan configured, so EOS defaults to vlan 1.
    uplink_native_vlan: < vlan_id >

How to test

Added molecule coverage for various combinations

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 10, 2023 07:43
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 10, 2023
@carlbuchmann carlbuchmann self-requested a review February 10, 2023 13:26
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reviewed live with @ClausHolbechArista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants