Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Change default native vlan name #2563

Merged
merged 1 commit into from Feb 24, 2023
Merged

Refactor(eos_designs): Change default native vlan name #2563

merged 1 commit into from Feb 24, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Change default native vlan name

Component(s) name

arista.avd.eos_designs

Proposed changes

uplink_native_vlan was added in #2522. This PR changes the vlan name of the default created native vlan.

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 22, 2023 13:02
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Feb 22, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev5 milestone Feb 22, 2023
carlbuchmann
carlbuchmann approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann requested a review from a team February 23, 2023 15:25
emilarista
emilarista approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 7911477 into aristanetworks:devel Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.0.0-dev5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @carlbuchmann @emilarista