Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Deprecation of 'vlan_interfaces.ipv6_address_virtual' (singular) #2613

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Feat(eos_cli_config_gen): Deprecation of 'vlan_interfaces.ipv6_address_virtual' (singular) #2613

merged 7 commits into from
Mar 14, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Mar 10, 2023 •
edited

Change Summary

Deprecation of 'vlan_interfaces.ipv6_address_virtual' (singular)

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • Mark the variable as deprecated in schema.
    • Point to replacement variable and porting guide if applicable.
  • Add section in porting guide if complex migration is needed.
  • Update regular molecule scenarios to use the replacement variable.
    • Ensure no configuration changes.
  • Add the deprecated variable to molecule *_deprecated_vars
  • Update other roles to not output the deprecated variable
    • Ensure no configuration changes

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner March 10, 2023 08:52
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 10, 2023
@github-actions github-actions bot added the type: code quality CI and development toolset label Mar 10, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Deprecation of 'ipv6_address_virtual' (singular) Feat(eos_cli_config_gen): Deprecation of 'vlan_interfaces.ipv6_address_virtual' (singular) Mar 10, 2023
emilarista
emilarista approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emilarista emilarista mentioned this pull request Mar 10, 2023
Merged
4 tasks
@gmuloc gmuloc merged commit 2d82e42 into aristanetworks:devel Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: code quality CI and development toolset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @gmuloc @emilarista