Feat(eos_cli_config_gen): Add port-channel esi and rt deprecation warnings #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4 tasks
|
@emilarista please rebase this one and make sure you get deprecation warning when running with the old keys |
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
183eb9e
to
71eabef
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
type: documentation
Rebased and deprecation warnings are showing up in molecule like they should. |
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
71eabef
to
70f8feb
Compare
github-actions
bot
added
role: eos_designs
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
41a0174
to
c55653f
Compare
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
cc6ed37
to
3d1c8b7
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
83d862e
to
a3d0a96
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...molecule/eos_cli_config_gen_deprecated_vars/documentation/devices/port-channel-interfaces.md
Outdated
Show resolved
Hide resolved
...tions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/port-channel-interfaces.yml
Outdated
Show resolved
Hide resolved
rebasing
…s/schema_fragments/port_channel_interfaces.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
emilarista
force-pushed
the
esi_rt_deprecation_warnings
branch
from
05c237d
to
63aefa1
Compare
gmuloc
reviewed
May 9, 2023
...ections/arista/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LER2.md
Show resolved
Hide resolved
gmuloc
approved these changes
May 11, 2023
ClausHolbechArista
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Depends on #2369
Includes Claus' work from #2613
Adds deprecation warnings for old port-channel esi and rt vars which are replaced by ethernet_segment.identifier and ethernet_segment.route_target.
Related Issue(s)
Fixes #1297
Fixes aristanetworks/avd-internal#87
Component(s) name
arista.avd.eos_cli_config_genHow to test
Tested with molecule.
Checklist
Repository Checklist