Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Sort internal objects for consistent output #2988

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Sort internal objects for consistent output

Depending on the inventory ordering, the areas where we pass neighbor information might change.
This reveals itself with dynamic inventories, where the order may change from play to play.

Component(s) name

arista.avd.eos_designs>

Proposed changes

  • Sort inband management "parents"
  • Sort uplink peers
  • Sort trunk groups on vlans
  • Sort auto-created native-vlans

How to test

Seen in customer project using dynamic inventories.
Also seen with pyavd where the input inventory is sorted differently.

After applying these fixes, the output is consistent even when the inventory order changes.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 16, 2023 08:15
@ClausHolbechArista ClausHolbechArista added this to To Do in DK-PROJECT-02 via automation Jun 16, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.1.0-dev1 milestone Jun 16, 2023
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Jun 16, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jun 16, 2023
4 tasks
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit c3984e7 into aristanetworks:devel Jun 16, 2023
30 checks passed
DK-PROJECT-02 automation moved this from To Do to Done Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
DK-PROJECT-02
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants