Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: pyavd alpha #2989

Merged
merged 7 commits into from
Jun 16, 2023
Merged

Feat: pyavd alpha #2989

merged 7 commits into from
Jun 16, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 16, 2023 •
edited
Loading

Based on PRs #2988 and #2986 which must be merged first and then this one can be rebased.

Change Summary

pyavd alpha

Proposed changes

  • pyavd consumes code from ansible-avd.

How to test

cd <root of repo>
make pyavd-test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 16, 2023 11:10
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation type: Python filters labels Jun 16, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as draft June 16, 2023 11:10
@github-actions github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role type: Python filters labels Jun 16, 2023
@carlbuchmann carlbuchmann marked this pull request as ready for review June 16, 2023 14:21
@github-actions github-actions bot added the type: dependencies Pull requests that update a dependency file label Jun 16, 2023
carlbuchmann
carlbuchmann approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit c9d250d into aristanetworks:devel Jun 16, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat state: CI Updated CI scenario have been updated in the PR type: dependencies Pull requests that update a dependency file type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @carlbuchmann