Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs,eos_cli_config_gen): Add hostname to structured configuration #3016

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Feat(eos_designs,eos_cli_config_gen): Add hostname to structured configuration #3016

merged 4 commits into from
Jul 6, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add hostname to structured configuration

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

  • Add hostname to schema for eos_cli_config_gen
  • Prefer hostname variable over inventory_hostname in eos_cli_config_gen
  • Output hostname from eos_designs

How to test

  • All eos_designs molecule scenarios reran. No config changes.
  • Added coverage to eos_cli_config_gen molecule to verify overriding inventory_hostname.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 3, 2023 10:55
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 3, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jul 3, 2023
Merged
4 tasks
carlbuchmann
carlbuchmann approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 47d145e into aristanetworks:devel Jul 6, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs|eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @carlbuchmann