Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Adjust pyavd API and requirements #3018

Merged
merged 7 commits into from Jul 6, 2023
Merged

Refactor: Adjust pyavd API and requirements #3018

merged 7 commits into from Jul 6, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jul 3, 2023 •
edited

Change Summary

Adjust pyavd API and requirements

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 3, 2023
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 3, 2023
@github-actions github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 6, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 6, 2023 13:03
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 6, 2023 13:03
carlbuchmann
carlbuchmann approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and reviewed new function naming.

@carlbuchmann carlbuchmann merged commit dd51212 into aristanetworks:devel Jul 6, 2023
34 checks passed
@gmuloc gmuloc mentioned this pull request Sep 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Refactor type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @carlbuchmann