-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support of route-target route-map for BGP VRFs #3222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this long overdue enhancement. You only cover VRFs. If it is not too much to ask, could you please check if the same is supported on EOS for VLANs and vlan-aware-bundles. If so, we should add it now to be consistent.
Note that for vlans and vlan-aware-bundles you also need to update the device documentation template. Just add the route-map to the list of exported/imported RTs like route-map <name>
As per my check, route-target route-map is only meant for VRFs, not for MAC-VRFs |
Thank you for checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again for this contribution.
Change Summary
Adding the ability to configure, at BGP/VRF level, a route-map for import/export from/to VPN or EVPN table
Related Issue(s)
Fixes #3127
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
1/ Changed the router-bgp schema fragment
2/ Changed the associated Jinja2 template
PS: No change to template documentation as there is no section for VRF route-targets
How to test
1/ Modified molecule eos_cli_config_gen inventory host_vars "router-bgp-v4-v6-evpn.yml" by adding import + export route-map
2/ Confirmed the generated eos configuration is OK
User Checklist
Repository Checklist