Feat(eos_cli_config_gen): Support of route-target route-map for BGP VRFs #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
There was a problem hiding this comment.
Thank you for this long overdue enhancement. You only cover VRFs. If it is not too much to ask, could you please check if the same is supported on EOS for VLANs and vlan-aware-bundles. If so, we should add it now to be consistent.
Note that for vlans and vlan-aware-bundles you also need to update the device documentation template. Just add the route-map to the list of exported/imported RTs like route-map <name>
|
As per my check, route-target route-map is only meant for VRFs, not for MAC-VRFs |
ClausHolbechArista
changed the title
Thank you for checking. |
ClausHolbechArista
approved these changes
Oct 10, 2023
gmuloc
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adding the ability to configure, at BGP/VRF level, a route-map for import/export from/to VPN or EVPN table
Related Issue(s)
Fixes #3127
Component(s) name
arista.avd.eos_cli_config_genProposed changes
1/ Changed the router-bgp schema fragment
2/ Changed the associated Jinja2 template
PS: No change to template documentation as there is no section for VRF route-targets
How to test
1/ Modified molecule eos_cli_config_gen inventory host_vars "router-bgp-v4-v6-evpn.yml" by adding import + export route-map
2/ Confirmed the generated eos configuration is OK
User Checklist
Repository Checklist