Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cv_configlet : fix bugs where some configlet with small changes were not updated #136

Merged
merged 7 commits into from
Feb 11, 2020

Conversation

b-abadie
Copy link
Contributor

This fixes #135

This PR fixes two bugs (one confirmed, and one suspected):

  • The usage of quick_ratio() can sometimes return 1.0 (i.e. no difference between current version and desired version) when changes are very small. In fact, the documentation specifies that this function is faster but only returns an upper bound instead of the actual value. This PR fixes the bug by using ratio() instead.
  • This is a suspected bug : by rounding the returned ratio, a very large configlet with a very small change could be considered unchanged. This PR removes the rounding (and the transformation to a percentage that seems useless to me).

@titom73 titom73 changed the base branch from master to releases/v1.0.x February 11, 2020 14:35
@titom73 titom73 merged commit 0c63d3e into aristanetworks:releases/v1.0.x Feb 11, 2020
@titom73 titom73 added the status: testing PR under testing label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing PR under testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cv_configlet : small changes do not trigger configlet update
3 participants