New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add rewrite back to generic test #387

Merged

gmuloc merged 1 commit into aristanetworks:main from gmuloc:issue/385

Sep 13, 2023

Collaborator

gmuloc commented Sep 12, 2023

Fixes #385

Because of the voodoo magic from @mtache we need to tell pytest to rewrite the asserts on tests.lib.anta when it is imported.

Tested manually:

modify one test to make it fail - check that the assertion message is comprehensive
comment the line in conftest and run again - check that you get only Assertion Error

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)


          chore: Add rewrite back to generic test

3920b0b

github-actions bot assigned gmuloc

gmuloc merged commit a80f788 into aristanetworks:main

16 checks passed

github-actions bot added the rn: chore label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment