Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Better error message for NTP test #401

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix(anta.tests): Better error message for NTP test #401

merged 1 commit into from
Sep 18, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Sep 18, 2023

Description

cf title

Fixes #396

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@carl-baillargeon carl-baillargeon changed the title fix(anta.test): Better error message for NTP test fix(anta.tests): Better error message for NTP test Sep 18, 2023
carl-baillargeon
carl-baillargeon approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 251dd31 into aristanetworks:main Sep 18, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NTP
2 participants
@gmuloc @carl-baillargeon