Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix wrong test name #464

Merged
merged 1 commit into from
Nov 16, 2023
Merged

doc: Fix wrong test name #464

merged 1 commit into from
Nov 16, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 15, 2023

Description

Legacy test name

Fixes #458

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc added this to the v1.0.0 milestone Nov 15, 2023
@titom73 titom73 self-requested a review November 16, 2023 12:07
titom73
titom73 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit 4b40ca7 into aristanetworks:main Nov 16, 2023
14 checks passed
@titom73 titom73 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: doc
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

doc: VerifyEosVersion -> VerifyEOSVersion
2 participants
@gmuloc @titom73