Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta.tests): Remove decorator and deprecated tests #473

Merged
merged 5 commits into from
Nov 22, 2023
Merged

refactor(anta.tests): Remove decorator and deprecated tests #473

merged 5 commits into from
Nov 22, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 21, 2023

Description

cf title

Fixes #440

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

mtache
mtache approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is satisfying.

@mtache mtache merged commit 2db3d7b into aristanetworks:main Nov 22, 2023
19 checks passed
@gmuloc gmuloc mentioned this pull request Nov 22, 2023
Merged
6 tasks
@titom73 titom73 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache approved these changes

@titom73 titom73 Awaiting requested review from titom73

Assignees

@gmuloc gmuloc

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate useless validators (BGP)
2 participants
@gmuloc @mtache