Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(anta): Use Ruff and remove black and flake8 #476

Merged
merged 76 commits into from
Mar 14, 2024
Merged

chore(anta): Use Ruff and remove black and flake8 #476

merged 76 commits into from
Mar 14, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 22, 2023 •
edited by mtache
Loading

Description

Ruff work
https://docs.astral.sh/ruff/faq/

Fixes #475

  1. Remove black, flake8 and isort
  2. Install Ruff
  3. Create Ruff rules (ignore/select) and refactor

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mtache mtache changed the title WIP chore(anta): Use Ruff and remove black and flake8 Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtache mtache marked this pull request as ready for review March 12, 2024 19:51
gmuloc
gmuloc commented Mar 13, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Show resolved Hide resolved
anta/cli/exec/utils.py Outdated Show resolved Hide resolved
anta/cli/utils.py Show resolved Hide resolved
gmuloc
gmuloc commented Mar 13, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Mar 13, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
mtache and others added 2 commits March 13, 2024 11:24
@mtache @gmuloc
Update pyproject.toml
2fa0d81 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@gmuloc
CI: Ruff for test_logger
81fa2e1
@gmuloc
Copy link
Collaborator Author

gmuloc commented Mar 14, 2024

:shipit: ?

carl-baillargeon
carl-baillargeon approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on real hardware. Tested all CLI functionalities.

@titom73 titom73 self-requested a review March 14, 2024 14:30
titom73
titom73 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit 735b043 into aristanetworks:main Mar 14, 2024
19 checks passed
This was referenced Mar 18, 2024
Closed
Closed
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache left review comments

@titom73 titom73 titom73 approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: chore(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: enable Ruff
4 participants
@gmuloc @mtache @titom73 @carl-baillargeon