feat(anta.tests): Added testcase to verify ip address on interface #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
commented
Jan 29, 2024
anta/tests/interfaces.py
Outdated
| input_secondary_ips = sorted([str(net) for net in command.params["secondary_ips"]]) | ||
|
|
||
| # Check if the interface has an IP address configured | ||
| if not (interface_output := get_value(command.json_output, f"interfaces..{intf}..interfaceAddress", separator="..")): |
There was a problem hiding this comment.
need to remove separator
carl-baillargeon
requested changes
Feb 22, 2024
anta/tests/interfaces.py
Outdated
| class Input(AntaTest.Input): | ||
| """Inputs for the VerifyInterfaceIPv4 test.""" | ||
|
|
||
| interfaces: List[Interfaces] |
There was a problem hiding this comment.
Suggested change
| interfaces: List[Interfaces] | |
| interfaces: List[InterfaceDetail] |
anta/tests/interfaces.py
Outdated
| """Name of the interface""" | ||
| primary_ip: IPv4Network | ||
| """Primary IPv4 network on interface""" | ||
| secondary_ips: List[IPv4Network] |
There was a problem hiding this comment.
secondary_ips should be optional. Only check them if they are provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added testcase to verify ip address(primary and secondary) on interface.
Fixes #545
Expected Results:
* success: The test will pass if an interface is configured with a correct primary and secondary IPv4 address.
* failure: The test will fail if an interface is not found or the primary and secondary IPv4 addresses do not match with the input.
Note: There is no optional input. All the input is required and restricted with values.
Checklist:
pre-commit run)tox -e testenv)