feat(anta.tests): Added testcase to verify interface speed #552

MaheshGSLAB · 2024-02-05T09:34:35Z

Description

Added testcase to verify the interface speed.

Verifies the speed, lanes, auto-negotiation status, and mode as full duplex for interfaces.

If speed is auto then verify auto-negotiation as success and mode as full duplex.
If speed is auto with a value(auto 10g) then verify auto-negotiation as success, mode as full duplex and speed/lanes as per input.
If speed is forced with a value(forces 10g) then verify mode as full duplex and speed as per input.
If speed with lane(100g-8) then verify mode as full duplex and speed/lanes as per input.

Fixes #542

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have run pre-commit for code linting and typing (pre-commit run)
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB · 2024-02-05T11:19:06Z

anta/tests/interfaces.py

+
+            # Collecting actual interface details
+            actual_interface_output = {
+                "auto negotiation": auto_negotiation if "auto" in interface.speed else "None",


"None" need to replace with Null

Why are you using "None"? It looks wrong no?

To create a generalize dict of actual and expected speed details of various type of speeds i used "None" in case that parameter is not needed for verification. For example if speed is 100g-4 in that case we dont need to validate auto negotiation hence updating auto negotiation key as None in both actual and expected output. So while comparing both actual and expected parameters match. I know if speed is 100g-4 in that case we should not define auto negotiation in actual and expected output but to achieve this we will have multiple condition for each type.

Let me know in case we need to change it.

If we need a string let's put N/A

anta/tests/interfaces.py

anta/custom_types.py

anta/tests/interfaces.py

carl-baillargeon · 2024-02-21T21:50:20Z

anta/tests/interfaces.py

+
+            # Collecting actual interface details
+            actual_interface_output = {
+                "auto negotiation": auto_negotiation if "auto" in interface.speed else "None",


Why are you using "None"? It looks wrong no?

github-actions · 2024-02-23T01:47:02Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-02-23T10:27:50Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon · 2024-02-23T13:23:00Z

anta/tests/interfaces.py

+
+            # Collecting actual interface details
+            actual_interface_output = {
+                "auto negotiation": auto_negotiation if "auto" in interface.speed else "None",


If we need a string let's put N/A

github-actions · 2024-02-23T15:34:04Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-02-27T13:49:42Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/custom_types.py

anta/tests/interfaces.py

anta/custom_types.py

anta/tests/interfaces.py

anta/tools/utils.py

anta/tests/interfaces.py

anta/tools/utils.py

tests/units/anta_tests/test_interfaces.py

github-actions · 2024-03-19T12:06:09Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tools/utils.py

anta/tests/interfaces.py

github-actions · 2024-03-29T16:36:59Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-04-16T05:59:09Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/tests/interfaces.py

anta/tools.py

carl-baillargeon · 2024-04-22T14:33:53Z

anta/tests/interfaces.py

+    - If the speed is set to auto with a value (e.g., 'auto 10g'), the class verifies that auto-negotiation is successful,
+      the mode is set to full duplex, and the speed/lanes match the input.
+    - If the speed is set with a lane value (e.g., '100g-8'), the class verifies that the mode is set to full duplex and
+      the speed/lanes match the input.


Does this still reflect the latest changes?

updated. Thanks

carl-baillargeon · 2024-04-22T14:36:45Z

anta/tests/interfaces.py

+    * Success: The test will pass if an interface is configured correctly with the specified speed, lanes, auto-negotiation status, and mode.
+    * Failure: The test will fail if an interface is not found, or if the speed, lanes, auto-negotiation status, or mode do not match the input.


I don't think this reflects the latest changes since duplex mode is not an input anymore?

updated. Thanks

carl-baillargeon

Small adjustments for docstrings otherwise LGTM. Tested locally.

issue-542: Added testcase to verify interface speed

0e1243d

github-actions bot assigned MaheshGSLAB Feb 5, 2024

MaheshGSLAB commented Feb 5, 2024

View reviewed changes

MaheshGSLAB requested review from carl-baillargeon and gmuloc February 6, 2024 08:10

MaheshGSLAB marked this pull request as ready for review February 6, 2024 08:11

carl-baillargeon requested changes Feb 21, 2024

View reviewed changes

github-actions bot added the state: conflict label Feb 23, 2024

issue-542: resolved conflicts and added unit tests for util function

16c6a8f

github-actions bot removed the state: conflict label Feb 23, 2024

carl-baillargeon requested changes Feb 23, 2024

View reviewed changes

issue-542: resolved conflicts and updated doc string

0dc4f32

github-actions bot added the state: conflict label Feb 23, 2024

issue-542: resolved conflicts and changed NA to N/A

55d3dcf

github-actions bot removed the state: conflict label Feb 27, 2024

gmuloc reviewed Mar 4, 2024

View reviewed changes

issue-542: updated interface pattern to support Ethernet1/1/1

43a1ae8

MaheshGSLAB requested review from gmuloc and carl-baillargeon March 5, 2024 06:44

issue-542: added util changes

e856c9d

gmuloc reviewed Mar 5, 2024

View reviewed changes

anta/tests/interfaces.py Outdated Show resolved Hide resolved

gmuloc reviewed Mar 5, 2024

View reviewed changes

anta/tools/utils.py Outdated Show resolved Hide resolved

tests/units/anta_tests/test_interfaces.py Outdated Show resolved Hide resolved

gmuloc and others added 2 commits March 5, 2024 14:19

ci: Accept bigger modules

4f9ba1d

issue-542: updated the speed pattern

a57eaee

MaheshGSLAB requested a review from gmuloc March 5, 2024 14:48

issue-542: fixed the CI

3588e8c

github-actions bot removed the state: conflict label Mar 19, 2024

MaheshGSLAB added 3 commits March 19, 2024 06:06

issue-542: fixed the CI checks

d3f6533

Merge branch 'main' into issue-542

860cc75

issue-542: added the example in doc string

6d1bb55

gmuloc reviewed Mar 20, 2024

View reviewed changes

anta/tools/utils.py Outdated Show resolved Hide resolved

gmuloc reviewed Mar 20, 2024

View reviewed changes

anta/tests/interfaces.py Outdated Show resolved Hide resolved

MaheshGSLAB requested a review from gmuloc March 21, 2024 09:51

MaheshGSLAB and others added 2 commits March 22, 2024 15:38

Merge branch 'arista-netdevops-community:main' into issue-542

fd8a319

issue-542: Updated the interface speed testcase with new changes

2f5b676

MaheshGSLAB requested a review from carl-baillargeon March 22, 2024 14:14

github-actions bot added the state: conflict label Mar 29, 2024

gmuloc added this to the v1.0.0 milestone Apr 12, 2024

Merge branch 'main' into issue-542

abfd9d5

github-actions bot removed the state: conflict label Apr 16, 2024

issue-542: fix the changes for pylintrc file

d5ca627

gmuloc reviewed Apr 18, 2024

View reviewed changes

anta/tests/interfaces.py Outdated Show resolved Hide resolved

anta/tests/interfaces.py Outdated Show resolved Hide resolved

anta/tools.py Outdated Show resolved Hide resolved

anta/tools.py Outdated Show resolved Hide resolved

gmuloc and others added 3 commits April 18, 2024 22:28

Apply suggestions from code review

2ee2503

Merge branch 'main' into issue-542

adf8f23

Merge branch 'main' into issue-542

5663d81

MaheshGSLAB requested a review from gmuloc April 19, 2024 09:21

gmuloc added the network-tests label Apr 22, 2024

carl-baillargeon reviewed Apr 22, 2024

View reviewed changes

carl-baillargeon approved these changes Apr 22, 2024

View reviewed changes

issue-542: updated the doc string

b2a0d38

gmuloc merged commit 7c8bf44 into aristanetworks:main Apr 23, 2024
17 checks passed

github-actions bot added the rn: feat(anta.tests) label Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(anta.tests): Added testcase to verify interface speed #552

feat(anta.tests): Added testcase to verify interface speed #552

MaheshGSLAB commented Feb 5, 2024

MaheshGSLAB Feb 5, 2024

carl-baillargeon Feb 21, 2024

MaheshGSLAB Feb 23, 2024

carl-baillargeon Feb 23, 2024

carl-baillargeon Feb 21, 2024

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

carl-baillargeon Feb 23, 2024

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Mar 19, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 16, 2024

carl-baillargeon Apr 22, 2024

MaheshGSLAB Apr 23, 2024

carl-baillargeon Apr 22, 2024

MaheshGSLAB Apr 23, 2024

carl-baillargeon left a comment

		* Success: The test will pass if an interface is configured correctly with the specified speed, lanes, auto-negotiation status, and mode.
		* Failure: The test will fail if an interface is not found, or if the speed, lanes, auto-negotiation status, or mode do not match the input.

feat(anta.tests): Added testcase to verify interface speed #552

feat(anta.tests): Added testcase to verify interface speed #552

Conversation

MaheshGSLAB commented Feb 5, 2024

Description

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Mar 19, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carl-baillargeon left a comment

Choose a reason for hiding this comment